capi: split silkworm_execute_blocks() into functions with ext and int txns
#1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gontech/silkworm into capi-signal-termination-fix2
This was referenced Mar 18, 2024
JacekGlen
changed the title
silkworm_execute_blocks() into functions with ext and int txns
canepat
added
the
maintenance
canepat
requested changes
Mar 20, 2024
canepat
approved these changes
Mar 20, 2024
JacekGlen
added a commit
to erigontech/erigon
that referenced
this pull request
Mar 29, 2024
This PR splits the existing `silkworm_execute_blocks` endpoint in CAPI and creates two separate endpoints: - `silkworm_execute_blocks_ephemeral`: takes a db txn as a parameter and uses it to flush the data, but does not commit the transaction - `silkworm_execute_blocks_perpetual`: creates its own db txn, commits the data and leaves the database in a coherent state Associated PRs: - erigontech/silkworm-go#4 - erigontech/silkworm#1917 --------- Co-authored-by: canepat <16927169+canepat@users.noreply.github.com> Co-authored-by: battlmonstr <battlmonstr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the existing
silkworm_execute_blocksendpoint in CAPI and creates two separate endpoints:silkworm_execute_blocks_ephemeral: takes a db txn as a parameter and uses it to flush the data, but does not commit the transactionsilkworm_execute_blocks_perpetual: creates its own db txn, commits the data and leaves the database in a coherent stateThe change cleans up the code and structures it in a more logical way. It also lays the ground for future improvements.
Associated PRs: