rpcdaemon: negotiation and validation of HTTP compression scheme #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lupin012
changed the title
canepat
changed the title
canepat
approved these changes
Mar 19, 2024
silkworm/rpc/http/connection.cpp
Outdated
| @@ -42,6 +43,7 @@ namespace silkworm::rpc::http { | |||
| static constexpr std::string_view kMaxAge{"600"}; | |||
| static constexpr auto kMaxPayloadSize{30 * kMebi}; // 30MiB | |||
| static constexpr std::array kAcceptedContentTypes{"application/json", "application/jsonrequest", "application/json-rpc"}; | |||
| static std::vector<std::string> SupportedCompressionList{"gzip"}; // specify the compression algo in priority level | |||
There was a problem hiding this comment.
Given that we need to support just one compression scheme (i.e. gzip), it's better to avoid handling a list of schemes: we will do it in the future if necessary. No need to do the changes here, next PR is fine
| boost::iostreams::filtering_ostream out; | ||
| out.push(boost::iostreams::gzip_compressor()); | ||
| out.push(boost::iostreams::back_inserter(compressed_data)); | ||
| boost::iostreams::copy(boost::make_iterator_range(clear_data), out); |
There was a problem hiding this comment.
You can probably improve here by keeping the boost::iostreams::filtering_ostream instance and the compressed data buffer as state variables in http::Connection in order to have gzip initialisation/finalisation happen only once per connection (as opposed to doing it for every data compression). Next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.