Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapshots: refactorings #1911

Merged
merged 8 commits into from
Mar 18, 2024
Merged

snapshots: refactorings #1911

merged 8 commits into from
Mar 18, 2024

Conversation

battlmonstr
Copy link
Contributor

@battlmonstr battlmonstr commented Mar 14, 2024 •
edited
Loading

  • MemoryMappedRegion: use span
  • Decompressor::Iterator as input_iterator
  • refactor tx_buffer_hash calculation
  • fix sys tx hash (snapshots: fix system tx hash in transactions indexes erigon#9727)
  • build tx indexes separately (doesn't affect perf)
  • refactor RecSplit.build_without_collisions
  • RecSplit.add_key: use ByteView instead of ptr+len

@battlmonstr battlmonstr force-pushed the pr/snap_refac branch 2 times, most recently from 2a27986 to bebf98c Compare March 15, 2024 17:20
@battlmonstr battlmonstr changed the title MemoryMappedRegion: use span snapshots: refactoring Mar 15, 2024
@battlmonstr battlmonstr changed the title snapshots: refactoring snapshots: refactorings Mar 15, 2024
@battlmonstr battlmonstr force-pushed the pr/snap_refac branch 2 times, most recently from 2b223df to ae2fb1d Compare March 17, 2024 16:50
@battlmonstr battlmonstr force-pushed the pr/snap_refac branch 2 times, most recently from 08c4dc9 to 2106118 Compare March 17, 2024 17:39
@battlmonstr battlmonstr marked this pull request as ready for review March 18, 2024 11:25
Base automatically changed from pr/chain_head to master March 18, 2024 20:15
@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Mar 18, 2024
@canepat canepat merged commit 85ba517 into master Mar 18, 2024
3 checks passed
@canepat canepat deleted the pr/snap_refac branch March 18, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canepat canepat canepat approved these changes

Assignees
No one assigned
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@battlmonstr @canepat