Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per ACD meeting 107 EIP-2315 was removed from Berlin #175

Merged
merged 1 commit into from
Mar 5, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ commands:
- run:
name: "Ethereum consensus tests"
working_directory: ~/build
command: cmd/consensus
command: cmd/consensus --skip-eip-2315

jobs:
linux-gcc-7:
Expand Down Expand Up @@ -99,7 +99,7 @@ jobs:
name: "Ethereum consensus tests"
working_directory: ~/build
command: |
cmd/consensus
cmd/consensus --skip-eip-2315
mv default.profraw consensus.profraw
- run:
name: "Coverage"
Expand Down
2 changes: 1 addition & 1 deletion .gitmodules
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[submodule "evmone"]
path = evmone
url = https://github.com/torquem-ch/evmone.git
branch = eip-2315
branch = eip-2929
[submodule "secp256k1"]
path = secp256k1
url = https://github.com/bitcoin-core/secp256k1.git
Expand Down
2 changes: 1 addition & 1 deletion appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,4 @@ test_script:
- cd Build
- cmd\Release\core_test.exe
- cmd\Release\db_test.exe
- cmd\Release\consensus.exe
- cmd\Release\consensus.exe --skip-eip-2315
36 changes: 0 additions & 36 deletions core/silkworm/execution/evm_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -312,40 +312,4 @@ TEST_CASE("Contract overwrite") {
CHECK(res.gas_left == 0);
}

TEST_CASE("EIP-2315") {
Block block{};
block.header.number = 13'000'000;

evmc::address address{0x5a0b54d5dc17e0aadc383d2db43b0a0d3e029c4c_address};

// 0 PUSH1 => 02
// 2 PUSH1 => 03
// 4 PUSH1 => 0b
// 6 JUMPSUB
// 7 PUSH1 => 07
// 9 SSTORE
// 10 STOP
// 11 BEGINSUB
// 12 MUL
// 13 RETURNSUB
Bytes code{*from_hex("60026003600b5e600755005c025d")};

MemoryBuffer db;
IntraBlockState state{db};
state.set_code(address, code);

EVM evm{block, state};

Transaction txn{};
txn.from = address;
txn.to = address;

uint64_t gas{1'000'000};
CallResult res{evm.execute(txn, gas)};
REQUIRE(res.status == EVMC_SUCCESS);

auto key7{to_bytes32(*from_hex("07"))};
CHECK(to_hex(zeroless_view(state.get_current_storage(address, key7))) == "06");
}

} // namespace silkworm
2 changes: 1 addition & 1 deletion evmone