Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tests submodule to last rev before Berlin #165

Closed
wants to merge 1 commit into from

Conversation

chfast
Copy link
Member

@chfast chfast commented Feb 19, 2021

In evmone I'm using a newer consensus tests revision (the last commit before Berlin is introduced).
I noticed it causes Silkworm some issues probably in test loading. Not investigated yet.

@yperbasis
Copy link
Member

In evmone I'm using a newer consensus tests revision (the last commit before Berlin is introduced).
I noticed it causes Silkworm some issues probably in test loading. Not investigated yet.

The problem is that in this revision BlockchainTests/ValidBlocks/bcStateTests/testOpcodes.json already uses not yet supported Berlin network.

@yperbasis
Copy link
Member

Closing since PR #161 updates consensus tests to Berlin (v7.0.1)

@yperbasis yperbasis closed this Feb 19, 2021
@yperbasis yperbasis deleted the update_tests branch July 18, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants