Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: revalidate canonical chain with one forward cycle at startup #1511

Merged
merged 10 commits into from
Sep 11, 2023

Conversation

canepat
Copy link
Member

@canepat canepat commented Sep 11, 2023

node: handle already existing canonical block in main chain verification
node: avoid committing changes for invalid block in Execution stage

canepat and others added 10 commits September 11, 2023 09:47
@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Sep 11, 2023
@canepat canepat requested a review from mriccobene September 11, 2023 16:24
@canepat canepat merged commit 7fad1b4 into master Sep 11, 2023
@canepat canepat deleted the node_improve_main_chain branch September 11, 2023 20:00
battlmonstr pushed a commit that referenced this pull request Sep 18, 2024
Fixes #2359

This PR restores in stage Execution the invalid block handling logic removed in #1511

Also fixes the invalid block reference lifetime issue causing an incorrect block hash to be stored as bad block hash in SyncContext and displayed into the warning log, as described in #2358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants