Skip to content

Commit

Permalink
rpcdaemon: fix storage location as quantity in eth_getStorageAt (#2774)
Browse files Browse the repository at this point in the history
  • Loading branch information
lupin012 authored Mar 5, 2025
1 parent 063458f commit 9912e31
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/rpc-integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- name: Checkout RPC Tests Repository & Install Requirements
run: |
rm -rf ${{runner.workspace}}/rpc-tests
git -c advice.detachedHead=false clone --depth 1 --branch v1.48.0 https://github.com/erigontech/rpc-tests ${{runner.workspace}}/rpc-tests
git -c advice.detachedHead=false clone --depth 1 --branch v1.49.0 https://github.com/erigontech/rpc-tests ${{runner.workspace}}/rpc-tests
cd ${{runner.workspace}}/rpc-tests
pip3 install -r requirements.txt --break-system-packages
Expand Down
2 changes: 1 addition & 1 deletion silkworm/rpc/commands/eth_api.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1096,7 +1096,7 @@ Task<void> EthereumRpcApi::handle_eth_get_storage_at(const nlohmann::json& reque

const auto address = params[0].get<evmc::address>();
const auto position = params[1].get<std::string>();
if (!is_valid_hex(position) || position.length() != 2 + kHashLength * 2) {
if (!is_valid_hex(position)) {
const auto error_msg = "unable to decode storage key: hex string invalid: " + params.dump();
SILK_ERROR << error_msg;
reply = make_json_error(request, kInvalidParams, error_msg);
Expand Down

0 comments on commit 9912e31

Please sign in to comment.