breaking change: remove txn.RawRead field (#89)

* save

* save

exp/mdbxpool/txnpool.go

@@ -121,7 +121,6 @@ func (p *TxnPool) beginReadonly() (*mdbx.Txn, error) {
 	// Clear txn.Pooled to let a warning be emitted from the Txn finalizer
 	// again.  And, make sure to clear RawRead to make the Txn appear like it
 	// was just allocated.
-	txn.RawRead = false
 	txn.Pooled = false
 
 	return txn, nil

mdbx/cursor.go

@@ -154,13 +154,7 @@ func (c *Cursor) Get(setkey, setval []byte, op uint) (key, val []byte, err error
 	// routines will be bad for the Go runtime when operating on Go memory
 	// (panic or potentially garbage memory reference).
 	if op == Set {
-		if c.txn.RawRead {
-			key = setkey
-		} else {
-			p := make([]byte, len(setkey))
-			copy(p, setkey)
-			key = p
-		}
+		key = setkey
 	} else {
 		if op != LastDup {
 			key = c.txn.bytes(c.txn.key)

mdbx/cursor_test.go

@@ -304,7 +304,6 @@ func TestLastDup(t *testing.T) {
 	}
 
 	err = env.View(func(txn *Txn) error {
-		txn.RawRead = true
 		c, err := txn.OpenCursor(dbi)
 		if err != nil {
 			return err
@@ -649,7 +648,6 @@ func TestCursor_Del(t *testing.T) {
 	}
 
 	err = env.Update(func(txn *Txn) (err error) {
-		txn.RawRead = true
 		cur, err := txn.OpenCursor(db)
 		if err != nil {
 			return err
@@ -692,7 +690,6 @@ func TestCursor_Del(t *testing.T) {
 
 	var newitems []Item
 	err = env.View(func(txn *Txn) (err error) {
-		txn.RawRead = true
 		cur, err := txn.OpenCursor(db)
 		if err != nil {
 			return err

mdbx/txn.go

@@ -55,12 +55,6 @@ type Txn struct {
 
 	errLogf func(format string, v ...interface{})
 
-	// If RawRead is true []byte values retrieved from Get() calls on the Txn
-	// and its cursors will point directly into the memory-mapped structure.
-	// Such slices will be readonly and must only be referenced wthin the
-	// transaction's lifetime.
-	RawRead bool
-
 	// Pooled may be set to true while a Txn is stored in a sync.Pool, after
 	// Txn.Reset reset has been called and before Txn.Renew.  This will keep
 	// the Txn finalizer from unnecessarily warning the application about
@@ -503,10 +497,7 @@ func (txn *Txn) subFlag(flags uint, fn TxnOp) error {
 }
 
 func (txn *Txn) bytes(val *C.MDBX_val) []byte {
-	if txn.RawRead {
-		return getBytes(val)
-	}
-	return getBytesCopy(val)
+	return getBytes(val)
 }
 
 // Get retrieves items from database dbi.  If txn.RawRead is true the slice