-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caplin: beacon committee subscription api #9721
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domiwei
changed the title
[WIP] Beacon committee subscription
[WIP] Caplin: beacon committee subscription api
Mar 15, 2024
Giulio2002
reviewed
Mar 15, 2024
domiwei
force-pushed
the
beacon_committee_subscription
branch
from
March 22, 2024 08:08
dceafd1
to
91c56aa
Compare
Giulio2002
reviewed
Mar 25, 2024
General feedback: Maybe for aggregating signatures and public key it is better to do another |
domiwei
changed the title
[WIP] Caplin: beacon committee subscription api
Caplin: beacon committee subscription api
Mar 27, 2024
Giulio2002
reviewed
Mar 27, 2024
Giulio2002
requested changes
Mar 30, 2024
Giulio2002
reviewed
Mar 30, 2024
Giulio2002
requested changes
Apr 3, 2024
Quality Gate passedIssues Measures |
Giulio2002
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr implements following beacon api
https://ethereum.github.io/beacon-APIs/#/Validator/prepareBeaconCommitteeSubnet
Steps:
isAggregator
flag is on, prepare internal data structure to collect and aggregate incoming attestation.beacon_attestation_{subnet}
, so we are capable of receiving attestation data from peer.