Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polygon/sync: message listener to preserve peer events ordering #10032

Merged
merged 1 commit into from
Apr 23, 2024
Merged

polygon/sync: message listener to preserve peer events ordering #10032

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion polygon/p2p/message_listener.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,18 @@ func (ml *messageListener) notifyPeerEventObservers(peerEvent *sentry.PeerEvent)
ml.observersMu.Lock()
defer ml.observersMu.Unlock()

notifyObservers(ml.peerEventObservers, peerEvent)
// wait on all observers to finish processing the peer event before notifying them
// with subsequent events in order to preserve the ordering of the sentry messages
var wg sync.WaitGroup
for _, observer := range ml.peerEventObservers {
wg.Add(1)
go func(observer MessageObserver[*sentry.PeerEvent]) {
defer wg.Done()
observer(peerEvent)
}(observer)
}

wg.Wait()
return nil
}

Expand Down
Loading