Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement debug_getBadBlocks #8171

Closed
yperbasis opened this issue Sep 10, 2023 · 2 comments
Closed

Implement debug_getBadBlocks #8171

yperbasis opened this issue Sep 10, 2023 · 2 comments
Assignees
@sudeepdino008
Labels
imp1 High importance

Comments

@yperbasis
Copy link
Member

Useful for debugging issues around bad blocks, like the one we saw on Polygon after release 2.49.0. See the spec on https://ethereum.github.io/execution-apis/api-documentation/. We should also extend the output with the underlying reason why a block is marked as bad.
@github-actions
Copy link

This issue is stale because it has been open for 40 days with no activity. Remove stale label or comment, or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 21, 2023
@github-actions
Copy link

This issue was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 29, 2023
@yperbasis yperbasis reopened this Oct 29, 2023
@github-actions github-actions bot removed the Stale label Oct 30, 2023
@yperbasis yperbasis added the imp2 Medium importance label Apr 9, 2024
@yperbasis yperbasis added imp1 High importance and removed imp2 Medium importance labels Aug 22, 2024
@sudeepdino008 sudeepdino008 self-assigned this Aug 29, 2024
@sudeepdino008 sudeepdino008 mentioned this issue Sep 12, 2024
Merged
@yperbasis yperbasis added imp0 Critical importance imp1 High importance and removed imp1 High importance imp0 Critical importance labels Oct 25, 2024
somnathb1 pushed a commit that referenced this issue Dec 4, 2024
@sudeepdino008
jsonrpc: Implement debug_getBadBlocks (#11888)
53b973d 
#8171

- reference of rpc api query params/return value is taken from geth
[here](https://github.com/ethereum/go-ethereum/blob/b4d99e39176f89bb0ffbb32635e9cf17b5fd7367/eth/api_debug.go#L107)
- difference is that geth returns ALL bad blocks, this PR returns 100.
sudeepdino008 added a commit that referenced this issue Dec 4, 2024
@sudeepdino008
jsonrpc: Implement debug_getBadBlocks (#11888)
076577f 
#8171

- reference of rpc api query params/return value is taken from geth
[here](https://github.com/ethereum/go-ethereum/blob/b4d99e39176f89bb0ffbb32635e9cf17b5fd7367/eth/api_debug.go#L107)
- difference is that geth returns ALL bad blocks, this PR returns 100.
@somnathb1 somnathb1 mentioned this issue Jan 24, 2025
Merged
somnathb1 added a commit that referenced this issue Jan 24, 2025
@somnathb1
jsonrpc: move getBadBlocks to debug api (#13547)
81e91e5 
See #8171
and Previous PR which put this into `eth_` api -
#11888
somnathb1 added a commit that referenced this issue Jan 28, 2025
@somnathb1
jsonrpc: move getBadBlocks to debug api (#13547)
ebcec86 
See #8171
and Previous PR which put this into `eth_` api -
#11888
somnathb1 added a commit that referenced this issue Jan 28, 2025
@somnathb1
jsonrpc: move getBadBlocks to debug api (#13547)
956ce32 
See #8171
and Previous PR which put this into `eth_` api -
#11888
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sudeepdino008 sudeepdino008

Labels
imp1 High importance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sudeepdino008 @yperbasis