Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-introduce: state.NewCachedReader #10747

Closed
AskAlexSharov opened this issue Jun 14, 2024 · 2 comments
Closed

re-introduce: state.NewCachedReader #10747

AskAlexSharov opened this issue Jun 14, 2024 · 2 comments
Labels
complexity:medium Issue will takee around a week erigon3 imp2 Medium importance
Milestone
3.0.0-alpha4

Comments

@AskAlexSharov
Copy link
Collaborator

AskAlexSharov commented Jun 14, 2024 •
edited
Loading

we stoped use it here #10746 , because of bug (I think reason is: 1. StateCache works on incarnation and 2. Need delete all storage when delete account) #10444
But we don't know perf impact of cache. Need carefully re-introduce it and bench speed.

Of-course such cache will be useful for "remote rpcdaemon deploy", but it's rare.

Maybe cache need a bit change to use Domain concept. (not sure)
@AskAlexSharov AskAlexSharov mentioned this issue Jun 14, 2024
Merged
@AskAlexSharov AskAlexSharov added this to the 3.0.0-beta1 milestone Jun 14, 2024
@AskAlexSharov AskAlexSharov mentioned this issue Jun 18, 2024
Closed
AskAlexSharov added a commit that referenced this issue Jun 18, 2024
@AskAlexSharov
trace_block: to change reader's state for each txIndex (#10746)
d97d869 
for #10444
it also removing use of `state.NewCachedReader` seems need re-introduce
it in E3 - to see perf impact. Creating ticket for it:
#10747
@VBulikov VBulikov added the imp2 Medium importance label Jun 28, 2024
@AskAlexSharov AskAlexSharov added the complexity:medium Issue will takee around a week label Jul 26, 2024
@AskAlexSharov
Copy link
Collaborator Author

not so important after adding: ii_lru
but ii_lru works on low-level and not helpful over grpc (remote rpcdaemon)

@AskAlexSharov
Copy link
Collaborator Author

done

@yperbasis yperbasis modified the milestones: 3.0.0-beta1, 3.0.0-alpha4 Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
complexity:medium Issue will takee around a week erigon3 imp2 Medium importance
Projects
None yet
Milestone
3.0.0-alpha4
Development

No branches or pull requests
3 participants
@VBulikov @yperbasis @AskAlexSharov