no_panic_be_happy (#1586)

erigontech · Apr 6, 2021 · de4f680 · de4f680
1 parent bb25047
commit de4f680
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/ethdb/kv_lmdb.go b/ethdb/kv_lmdb.go
@@ -356,7 +356,7 @@ func (db *LmdbKV) CollectMetrics() {
 		tableGcEntries.Update(int64(stat.Entries))
 		return nil
 	}); err != nil {
-		panic(err)
+		log.Error("collecting metrics failed", "err", err)
 	}
 }
 

diff --git a/ethdb/kv_mdbx.go b/ethdb/kv_mdbx.go
@@ -344,7 +344,7 @@ func (db *MdbxKV) CollectMetrics() {
 		tableGcEntries.Update(int64(stat.Entries))
 		return nil
 	}); err != nil {
-		panic(err)
+		log.Error("collecting metrics failed", "err", err)
 	}
 }
 

diff --git a/ethdb/object_db.go b/ethdb/object_db.go
@@ -347,7 +347,7 @@ func (db *ObjectDatabase) NewBatch() DbWithPendingMutations {
 func (db *ObjectDatabase) Begin(ctx context.Context, flags TxFlags) (DbWithPendingMutations, error) {
 	batch := &TxDb{db: db}
 	if err := batch.begin(ctx, flags); err != nil {
-		panic(err)
+		return batch, err
 	}
 	return batch, nil
 }