Skip to content

Commit

Permalink
Fix NewPayload Validation during header download (#10837)
Browse files Browse the repository at this point in the history
Cherry pick PR #10093 into the release branch

Co-authored-by: Minhyuk Kim <kimminhyuk1004@gmail.com>
  • Loading branch information
yperbasis and mininny committed Jun 21, 2024
1 parent e8c5632 commit 478b5b2
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion turbo/engineapi/engine_server.go
Original file line number Diff line number Diff line change
Expand Up @@ -768,7 +768,18 @@ func (e *EngineServer) HandleNewPayload(
if !success {
return &engine_types.PayloadStatus{Status: engine_types.SyncingStatus}, nil
}
return &engine_types.PayloadStatus{Status: engine_types.ValidStatus, LatestValidHash: &headerHash}, nil

status, _, latestValidHash, err := e.chainRW.ValidateChain(ctx, headerHash, headerNumber)
if err != nil {
return nil, err
}

if status == execution.ExecutionStatus_Busy || status == execution.ExecutionStatus_TooFarAway {
e.logger.Debug(fmt.Sprintf("[%s] New payload: Client is still syncing", logPrefix))
return &engine_types.PayloadStatus{Status: engine_types.SyncingStatus}, nil
} else {
return &engine_types.PayloadStatus{Status: engine_types.ValidStatus, LatestValidHash: &latestValidHash}, nil
}
} else {
return &engine_types.PayloadStatus{Status: engine_types.SyncingStatus}, nil
}
Expand Down

0 comments on commit 478b5b2

Please sign in to comment.