Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom component for HA 0.92 #1

Merged
merged 5 commits into from
Aug 16, 2019
Merged

Fix custom component for HA 0.92 #1

merged 5 commits into from
Aug 16, 2019

Conversation

PeteCondliffe
Copy link

Created init.py and manifest.json
updated run.sh to copy these files in with the custom component

ericleb010
ericleb010 reviewed Aug 14, 2019
View reviewed changes
xboxone/run.sh Outdated Show resolved Hide resolved
ericleb010
ericleb010 requested changes Aug 15, 2019
View reviewed changes
Copy link
Owner

@ericleb010 ericleb010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Dockerfile, we'll need to bring in our new files:

- COPY run.sh /
- COPY xboxone.py /

+ COPY run.sh xboxone.py manifest.py __init__.py /

@PeteCondliffe
Copy link
Author

I added it as separate copies for some reason before seeing your comment and tested working that way on a new hassio build
Would have done it sooner but finally got my Xiaomi vacuum

@ericleb010
Copy link
Owner

Okay, tested it and it looks good. I'm going to accept the PR and probably edit the Dockerfile afterward. Thanks for the contribution 👍

@ericleb010 ericleb010 merged commit e1194af into ericleb010:master Aug 16, 2019
tuxuser referenced this pull request in OpenXbox/xboxone-home-assistant Feb 4, 2020
@PeteCondliffe @ericleb010
Fix custom component for HA 0.92 (#1)
8842c7c 
Adding manifest and init files on container start

Former-commit-id: e1194af
tuxuser referenced this pull request in OpenXbox/xboxone-home-assistant Feb 4, 2020
@PeteCondliffe @tuxuser
Fix custom component for HA 0.92 (#1)
400e541 
Adding manifest and init files on container start

Former-commit-id: e1194af
tuxuser referenced this pull request in OpenXbox/xboxone-home-assistant Feb 5, 2020
@PeteCondliffe @tuxuser
Fix custom component for HA 0.92 (#1)
27982b2 
Adding manifest and init files on container start
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericleb010 ericleb010 ericleb010 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PeteCondliffe @ericleb010