Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for React 15.0.0 #112

Merged
merged 1 commit into from
Apr 11, 2016
Merged

Adds support for React 15.0.0 #112

merged 1 commit into from
Apr 11, 2016

Conversation

EvHaus
Copy link
Contributor

@EvHaus EvHaus commented Apr 8, 2016

This PR adds support for React 15.

Changes made:

  • Updated package.json's peerDependencies
  • Updated package.json's devDependencies
  • Updated tests to use react-dom/server for renderToStaticMarkup instead of react.
  • The main Resolver.js code seems to already be using react-dom/server so no changes needed to be made there

Testing:

  • All tests pass via npm run test
  • Unable to run linting via npm run lint because the peerDependencies of eslint-config-future are not installed (resulting in eslint-config-future@2.1.1 requires a peer of babel-eslint@3.x but none was installed errors, etc..). And I was unable to manually install the required dependencies because eslint-config-future wants babel-eslint@3.1.x but that version of babel-eslint is broken due to this bug: TypeError: Cannot read property 'visitClass' of undefined babel/babel-eslint#243 No idea of linting will pass as a result of this.

@pwmckenna
Copy link
Collaborator

@EvNaverniouk We'll probably need to make some updates to https://github.com/ericclemmons/eslint-config-future to get this to lint, or switch to something like eslint-config-airbnb (my personal preference is of course eslint-config-pwmckenna ;) ) Anyhow, I ran this branch against a different lint config that just checks for syntactic errors and every thing looked good, so this feels ready to merge and release.

@ericclemmons this will result in "" rather than <noscript/> for unresolved components, which is sort of a breaking change, however its the default behavior of the react peer dependency, so how do you feel about a patch release?

@pwmckenna pwmckenna merged commit 6022360 into ericclemmons:master Apr 11, 2016
@pwmckenna
Copy link
Collaborator

@EvNaverniouk just published as 3.0.1. thanks for the PR!

ericclemmons added a commit that referenced this pull request Jun 29, 2016
* origin/master:
  3.0.1
  Adds support for React 15.0.0 (#112)
  Update README.md
  removing the react v0.13 example
  update the changelog with v3.0.0 changesa
  3.0.0
  fix the postversion npm script
  Update README.md
  Update devDependencies
  Use react-dom
ericclemmons added a commit that referenced this pull request Jun 30, 2016
* origin/master:
  3.0.1
  Adds support for React 15.0.0 (#112)
  Update README.md
  removing the react v0.13 example
  update the changelog with v3.0.0 changesa
  3.0.0
  fix the postversion npm script
  Update README.md
  Update devDependencies
  Use react-dom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants