Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES6 => ES5 #10

Merged
merged 11 commits into from
Feb 25, 2015
Merged

ES6 => ES5 #10

merged 11 commits into from
Feb 25, 2015

Conversation

ericclemmons
Copy link
Owner

  • Switch to ES6 for everything
  • Publish to ES5
  • Use peerDependencies for react
  • Use optionalDependencies for react-router

@ericclemmons ericclemmons mentioned this pull request Feb 25, 2015
Closed
@adri
Copy link
Contributor

adri commented Feb 25, 2015

Could npm link help you to test before releasing? https://docs.npmjs.com/cli/link

@adri
Copy link
Contributor

adri commented Feb 25, 2015

Ah I see you are already doing this for the example project. Doesn't that work as expected?

@ericclemmons
Copy link
Owner Author

The issue I'm having is that npm install --production still seems to install the peerDependencies as part of react-resolver, which I found odd...

@ericclemmons
Copy link
Owner Author

I'm publishing v0.1.0 to test it out by hand :)

ericclemmons added a commit that referenced this pull request Feb 25, 2015
@ericclemmons
Merge pull request #10 from ericclemmons/4-es5
f32fc3e 
ES6 => ES5
@ericclemmons ericclemmons merged commit f32fc3e into master Feb 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericclemmons @adri