recommended default: advertise SCRAM #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jwheare
IRCCloud attempts SCRAM-SHA-256 when it is advertised and does not fall back to PLAIN on failure. This will break authentication for accounts that were created on Ergo 2.7 or earlier, then never logged into again until the first time SCRAM-SHA-256 was advertised (because we only have bcrypt-based credentials and no SCRAM credentials). This is an unacceptable compatibility break, but it's also a weird enough edge case that IRCCloud will probably never fix it.
Compromise: make advertising it a recommended default, but require old servers to opt in explicitly. On a related note, SCRAM is bad and clients should not implement it.
Fixes #1782