Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show data provider details in slow test list #559

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented May 14, 2024

fix #553

Show data provider data the same way how PHPUnit default formatter report them.

In PHPUnit v9 and below this is already done.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.88%. Comparing base (1cb0438) to head (37be3a4).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #559   +/-   ##
=========================================
  Coverage     61.88%   61.88%           
  Complexity      116      116           
=========================================
  Files            28       28           
  Lines           585      585           
=========================================
  Hits            362      362           
  Misses          223      223           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mvorisek mvorisek force-pushed the fix_provider_data_show branch 3 times, most recently from 88ea864 to a89cf90 Compare May 14, 2024 09:23
@mvorisek
Copy link
Contributor Author

@localheinz can I ask you to review and help me fixing the CI as the code is not analyseable by PHP 7.4, as PHPUnit 10+ is not for PHP 7.4.

@localheinz
Copy link
Member

@mvorisek

I will take a look on the weekend!

@localheinz localheinz self-assigned this May 17, 2024
@mvorisek
Copy link
Contributor Author

@localheinz a month ago, you promised to look at this PR "on the weekend" - I know everyone is busy with somethings, but would you mind to look into the CI now? Thank you in advance!

@localheinz
Copy link
Member

Taking a look now, @mvorisek!

@localheinz localheinz force-pushed the fix_provider_data_show branch 3 times, most recently from 2d0579e to a79e4ae Compare June 16, 2024 18:14
@localheinz localheinz merged commit cb150ed into ergebnis:main Jun 16, 2024
63 checks passed
@localheinz
Copy link
Member

Thank you, @mvorisek!

@mvorisek mvorisek deleted the fix_provider_data_show branch June 16, 2024 23:51
@mvorisek
Copy link
Contributor Author

@localheinz Thank you ❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Values from data provider are not shown for slow test
2 participants