Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use a single space for and combinator #819

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

fredden
Copy link
Contributor

@fredden fredden commented Jan 10, 2023

This pull request is a small part of #756. This change should not introduce any controversy.

  • *and- constraints are always separated by a single space ( ), never a comma (,)

Related to #756

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #819 (d1e7cd7) into main (15c0c9a) will not change coverage.
The diff coverage is n/a.

❗ Current head d1e7cd7 differs from pull request most recent head 4df293a. Consider uploading reports for the commit 4df293a to get more accurate results

@@            Coverage Diff            @@
##               main     #819   +/-   ##
=========================================
  Coverage     98.06%   98.06%           
  Complexity      135      135           
=========================================
  Files            28       28           
  Lines           413      413           
=========================================
  Hits            405      405           
  Misses            8        8           
Impacted Files Coverage Δ
...rc/Vendor/Composer/VersionConstraintNormalizer.php 96.42% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@localheinz localheinz self-assigned this Feb 21, 2023
@localheinz localheinz changed the title Always use a single space for 'and' combinator Always use a single space for and combinator Feb 21, 2023
Copy link
Member

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@localheinz localheinz merged commit fb98420 into ergebnis:main Feb 21, 2023
@localheinz
Copy link
Member

Thank you, @fredden!

@fredden fredden deleted the always-space-for-and branch February 21, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants