Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correctly sort composer-plugin-api #463

Merged
merged 2 commits into from
Mar 6, 2021
Merged

Conversation

localheinz
Copy link
Member

This pull request

  • asserts that composer-plugin-api is correctly sorted

Related to ergebnis/composer-normalize#673.

@localheinz localheinz self-assigned this Mar 6, 2021
@localheinz localheinz marked this pull request as draft March 6, 2021 10:34
@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #463 (0923d66) into main (e1d2c72) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##                main      #463   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       164       164           
===========================================
  Files             34        34           
  Lines            515       515           
===========================================
  Hits             515       515           
Impacted Files Coverage Δ Complexity Δ
src/Vendor/Composer/PackageHashNormalizer.php 100.00% <ø> (ø) 7.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1d2c72...0e5baab. Read the comment docs.

@ergebnis-bot ergebnis-bot self-assigned this Mar 6, 2021
ergebnis-bot
ergebnis-bot previously approved these changes Mar 6, 2021
@ergebnis-bot ergebnis-bot merged commit a71c1a4 into main Mar 6, 2021
@ergebnis-bot ergebnis-bot deleted the fix/composer-plugin-api branch March 6, 2021 10:43
@rjgwiz
Copy link

rjgwiz commented Mar 30, 2022

This is still an issue for me.

composer.json:

    "require": {
        "php": ">=7.4",
        "composer-plugin-api": "^2.0",
        "acquia/blt": "^13",

command line outputs:

composer --version
Composer 2.3.1 2022-03-30 15:41:28
...
 - ergebnis/composer-normalize installed in version 2.25.1
...

$ composer validate
./composer.json is valid, but with a few warnings
See https://getcomposer.org/doc/04-schema.md for details on the schema
# General warnings
- require.drupal/security_review : unbound version constraints (*) should be avoided
- require.drupal/view_custom_table : exact version constraints (9.0.x-dev@dev) should be avoided if the package follows semantic versioning
Links under require section are not sorted.
$ composer normalize
Running ergebnis/composer-normalize by Andreas Möller and contributors.

./composer.json is already normalized.

Composer validate and composer normalize keep conflicting each other on the sorting placement of composer-plugin-api. Did something in Composer v2 reintroduce this bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants