Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use constants #427

Merged
merged 1 commit into from
Dec 31, 2020
Merged

Fix: Use constants #427

merged 1 commit into from
Dec 31, 2020

Conversation

localheinz
Copy link
Member

This PR

  • uses private constants instead of private, static fields

Follows #425 (comment).

/cc @Tobion

@codecov
Copy link

codecov bot commented Dec 31, 2020

Codecov Report

Merging #427 (2cb22d4) into main (f80e560) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##                main      #427   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       164       164           
===========================================
  Files             34        34           
  Lines            512       512           
===========================================
  Hits             512       512           
Impacted Files Coverage Δ Complexity Δ
src/Vendor/Composer/ConfigHashNormalizer.php 100.00% <100.00%> (ø) 8.00 <0.00> (ø)
src/Vendor/Composer/PackageHashNormalizer.php 100.00% <100.00%> (ø) 7.00 <0.00> (ø)
...rc/Vendor/Composer/VersionConstraintNormalizer.php 100.00% <100.00%> (ø) 7.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f80e560...2cb22d4. Read the comment docs.

@ergebnis-bot ergebnis-bot self-assigned this Dec 31, 2020
@ergebnis-bot ergebnis-bot merged commit 339b91a into main Dec 31, 2020
@ergebnis-bot ergebnis-bot deleted the fix/constant branch December 31, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants