Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Require localheinz/phpstan-rules #109

Merged
merged 4 commits into from
Dec 9, 2018

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Nov 25, 2018

This PR

  • requires localheinz/phpstan-rules
  • includes rules.neon from localheinz/phpstan-rules
  • fixes issues detected via static analysis
  • ignores an error related to an interface we don't control

@localheinz localheinz self-assigned this Nov 25, 2018
@codecov
Copy link

codecov bot commented Nov 25, 2018

Codecov Report

Merging #109 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #109   +/-   ##
=======================================
  Coverage       100%   100%           
+ Complexity      136    129    -7     
=======================================
  Files            30     30           
  Lines           415    404   -11     
=======================================
- Hits            415    404   -11
Impacted Files Coverage Δ Complexity Δ
src/SchemaNormalizer.php 100% <ø> (ø) 32 <0> (-3) ⬇️
src/IndentNormalizer.php 100% <100%> (ø) 2 <1> (-1) ⬇️
src/FixedFormatNormalizer.php 100% <100%> (ø) 2 <0> (-1) ⬇️
src/AutoFormatNormalizer.php 100% <100%> (ø) 2 <1> (-1) ⬇️
src/Format/Formatter.php 100% <100%> (ø) 3 <1> (-1) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2574e5c...4b45481. Read the comment docs.

@localheinz localheinz force-pushed the feature/phpstan-rules branch 5 times, most recently from 078f389 to 1132242 Compare December 3, 2018 19:49
@localheinz localheinz force-pushed the feature/phpstan-rules branch 2 times, most recently from 8c492ac to 230673e Compare December 7, 2018 16:46
@localheinz localheinz merged commit 7537dc0 into master Dec 9, 2018
@localheinz localheinz deleted the feature/phpstan-rules branch December 9, 2018 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant