Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Implement ChainUriRetriever #102

Merged
merged 1 commit into from
Nov 4, 2018

Conversation

localheinz
Copy link
Member

This PR

  • implements a ChainUriRetriever

Related to ergebnis/composer-normalize#80.

@localheinz localheinz self-assigned this Nov 4, 2018
@codecov
Copy link

codecov bot commented Nov 4, 2018

Codecov Report

Merging #102 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #102   +/-   ##
=======================================
  Coverage       100%   100%           
- Complexity      127    135    +8     
=======================================
  Files            28     30    +2     
  Lines           392    410   +18     
=======================================
+ Hits            392    410   +18
Impacted Files Coverage Δ Complexity Δ
src/Exception/UriRetrieverRequiredException.php 100% <100%> (ø) 1 <1> (?)
...rc/JsonSchema/Uri/Retrievers/ChainUriRetriever.php 100% <100%> (ø) 7 <7> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72c7335...a1d43dc. Read the comment docs.

@localheinz localheinz merged commit a4bb9dd into master Nov 4, 2018
@localheinz localheinz deleted the feature/chain-uri-retriever branch November 4, 2018 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant