Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PHP 8.0 #465

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Add support for PHP 8.0 #465

merged 1 commit into from
Jul 3, 2020

Conversation

core23
Copy link
Contributor

@core23 core23 commented Jun 21, 2020

This PR adds support for the upcoming PHP 8 release

@codecov
Copy link

codecov bot commented Jun 21, 2020 •
edited
Loading

Codecov Report

Merging #465 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #465   +/-   ##
=========================================
  Coverage     80.92%   80.92%           
  Complexity       41       41           
=========================================
  Files             4        4           
  Lines           194      194           
=========================================
  Hits            157      157           
  Misses           37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a2a311...0c5cb91. Read the comment docs.

@core23
Copy link
Contributor Author

core23 commented Jun 21, 2020

array and string offset access syntax with curly braces is no longer supported

Looks like this is not yet possible :(

@localheinz localheinz self-requested a review June 22, 2020 21:28
@localheinz localheinz self-assigned this Jun 22, 2020
@localheinz localheinz mentioned this pull request Jun 23, 2020
Merged
1 task
@localheinz localheinz mentioned this pull request Jun 23, 2020
Merged
1 task
@localheinz
Copy link
Member

@core23

Thank you for your pull request! I will take a look later.

@core23 core23 force-pushed the php8 branch 2 times, most recently from cb200af to 32fecbd Compare June 25, 2020 18:25
@localheinz localheinz force-pushed the php8 branch 3 times, most recently from a73ed6d to 3619dd9 Compare July 3, 2020 17:16
@localheinz localheinz mentioned this pull request Jul 3, 2020
Merged
2 tasks
localheinz
localheinz approved these changes Jul 3, 2020
View reviewed changes
Copy link
Member

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@localheinz localheinz merged commit ad7a078 into ergebnis:main Jul 3, 2020
@localheinz
Copy link
Member

Thank you, @core23!

@core23 core23 deleted the php8 branch July 3, 2020 20:27
@core23
Copy link
Contributor Author

core23 commented Jul 4, 2020

I wonder why composer could resolve this. There are some direct dependencies that do not have PHP 8 support 🤔

@localheinz
Copy link
Member

Ha, probably because of the platform configuration. I will take a look later!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@localheinz localheinz localheinz approved these changes

Assignees

@localheinz localheinz

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@core23 @localheinz