This repository has been archived by the owner on Jan 9, 2020. It is now read-only.
Issue #22: Add composer/composer as a dependency #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
=======================================
Coverage 100% 100%
- Complexity 26 27 +1
=======================================
Files 5 5
Lines 93 97 +4
=======================================
+ Hits 93 97 +4
Continue to review full report at Codecov.
|
localheinz
reviewed
Feb 19, 2019
| @@ -17,7 +17,8 @@ | |||
| ], | |||
| "require": { | |||
| "php": "^7.1", | |||
| "localheinz/json-normalizer": "~0.9.0" | |||
| "localheinz/json-normalizer": "~0.9.0", | |||
| "composer/composer": "^1" | |||
There was a problem hiding this comment.
The problem with this is that all we really need is the schema, not composer/composer as a dependency. As pointed out earlier, it was removed in #21.
There was a problem hiding this comment.
I think I will close this PR and use this: ergebnis/composer-normalize#80 (comment)
What do you think ?
|
Closed in favor of: ergebnis/composer-normalize#170 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related to ergebnis/composer-normalize#80.
Fixes #22.