Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add support for PHP 8.0 #235

Merged
merged 1 commit into from
Aug 30, 2020
Merged

Enhancement: Add support for PHP 8.0 #235

merged 1 commit into from
Aug 30, 2020

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Aug 29, 2020

This PR

  • adds support for PHP 8.0

💁‍♂️ For reference, see https://wiki.php.net/rfc/namespaced_names_as_token.

@codecov
Copy link

codecov bot commented Aug 29, 2020

Codecov Report

Merging #235 into main will decrease coverage by 0.67%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #235      +/-   ##
============================================
- Coverage     98.55%   97.87%   -0.68%     
- Complexity       48       50       +2     
============================================
  Files             6        6              
  Lines           138      141       +3     
============================================
+ Hits            136      138       +2     
- Misses            2        3       +1     
Impacted Files Coverage Δ Complexity Δ
src/Constructs.php 96.77% <75.00%> (-1.01%) 36.00 <0.00> (+2.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bc67be...f208cde. Read the comment docs.

@localheinz localheinz changed the title Enhancement: Run tests on PHP 8.0 Enhancement: Add support for PHP 8.0 Aug 30, 2020
@localheinz localheinz marked this pull request as ready for review August 30, 2020 10:11
@localheinz localheinz force-pushed the feature/php8 branch 3 times, most recently from f5d9f6b to 40a267e Compare August 30, 2020 10:16
@ergebnis-bot ergebnis-bot merged commit 0b04738 into main Aug 30, 2020
@ergebnis-bot ergebnis-bot deleted the feature/php8 branch August 30, 2020 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants