Skip to content

Commit

Permalink
Merge pull request #481 from ergebnis/fix/php72
Browse files Browse the repository at this point in the history
Fix: Drop support for PHP 7.2
  • Loading branch information
localheinz committed Dec 30, 2021
2 parents 8d30c4a + e7d15d8 commit 66d64e1
Show file tree
Hide file tree
Showing 21 changed files with 107 additions and 106 deletions.
13 changes: 5 additions & 8 deletions .github/settings.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,11 @@ branches:
required_approving_review_count: 1
required_status_checks:
contexts:
- "Code Coverage (7.2, locked)"
- "Coding Standards (7.2, locked)"
- "Dependency Analysis (7.2, locked)"
- "Mutation Tests (7.2, locked)"
- "Static Code Analysis (7.2, locked)"
- "Tests (7.2, highest)"
- "Tests (7.2, locked)"
- "Tests (7.2, lowest)"
- "Code Coverage (7.3, locked)"
- "Coding Standards (7.3, locked)"
- "Dependency Analysis (7.3, locked)"
- "Mutation Tests (7.3, locked)"
- "Static Code Analysis (7.3, locked)"
- "Tests (7.3, highest)"
- "Tests (7.3, locked)"
- "Tests (7.3, lowest)"
Expand Down
11 changes: 5 additions & 6 deletions .github/workflows/integrate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
strategy:
matrix:
php-version:
- "7.2"
- "7.3"

dependencies:
- "locked"
Expand Down Expand Up @@ -72,7 +72,7 @@ jobs:
strategy:
matrix:
php-version:
- "7.2"
- "7.3"

dependencies:
- "locked"
Expand Down Expand Up @@ -137,7 +137,7 @@ jobs:
strategy:
matrix:
php-version:
- "7.2"
- "7.3"

dependencies:
- "locked"
Expand Down Expand Up @@ -179,7 +179,7 @@ jobs:
strategy:
matrix:
php-version:
- "7.2"
- "7.3"

dependencies:
- "locked"
Expand Down Expand Up @@ -221,7 +221,7 @@ jobs:
strategy:
matrix:
php-version:
- "7.2"
- "7.3"

dependencies:
- "locked"
Expand Down Expand Up @@ -266,7 +266,6 @@ jobs:
strategy:
matrix:
php-version:
- "7.2"
- "7.3"
- "7.4"
- "8.0"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/renew.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
strategy:
matrix:
php-version:
- "7.2"
- "7.3"

dependencies:
- "locked"
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

For a full diff see [`1.2.0...main`][1.2.0...main].

### Fixed

- Dropped support for PHP 7.2 ([#481]), by [@localheinz]

## [`1.2.0`][1.2.0]

For a full diff see [`1.1.1...1.2.0`][1.1.0...1.2.0].
Expand Down Expand Up @@ -134,6 +138,7 @@ For a full diff see [`0.4.0...0.5.0`][0.4.0...0.5.0].
[#343]: https://github.com/ergebnis/classy/pull/343
[#467]: https://github.com/ergebnis/classy/pull/467
[#478]: https://github.com/ergebnis/classy/pull/478
[#481]: https://github.com/ergebnis/classy/pull/481

[@ergebnis]: https://github.com/ergebnis
[@localheinz]: https://github.com/localheinz
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"source": "https://github.com/ergebnis/classy"
},
"require": {
"php": "^7.2 || ^8.0",
"php": "^7.3 || ^8.0",
"ext-tokenizer": "*"
},
"require-dev": {
Expand Down Expand Up @@ -56,7 +56,7 @@
"ergebnis/composer-normalize": true
},
"platform": {
"php": "7.2.33"
"php": "7.3.32"
},
"preferred-install": "dist",
"sort-packages": true
Expand Down
6 changes: 3 additions & 3 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 0 additions & 9 deletions test/Fixture/Classy/Php72/WithinNamespace/source.php

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace Ergebnis\Classy\Test\Fixture\Classy\Php72\WithMethodsNamedAfterKeywords;
namespace Ergebnis\Classy\Test\Fixture\Classy\Php73\WithMethodsNamedAfterKeywords;

class Foo
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace Ergebnis\Classy\Test\Fixture\Classy\Php72\WithMethodsNamedAfterKeywordsAndReturnType;
namespace Ergebnis\Classy\Test\Fixture\Classy\Php73\WithMethodsNamedAfterKeywordsAndReturnType;


class Foo
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace Ergebnis\Classy\Test\Fixture\Classy\Php72\WithinMultipleNamespaces\Foo;
namespace Ergebnis\Classy\Test\Fixture\Classy\Php73\WithinMultipleNamespaces\Foo;
{
class Foo {}

Expand All @@ -9,7 +9,7 @@ interface Bar {}
trait Baz {}
}

namespace Ergebnis\Classy\Test\Fixture\Classy\Php72\WithinMultipleNamespaces\Bar;
namespace Ergebnis\Classy\Test\Fixture\Classy\Php73\WithinMultipleNamespaces\Bar;
{
class Foo {}

Expand Down
9 changes: 9 additions & 0 deletions test/Fixture/Classy/Php73/WithinNamespace/source.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?php

namespace Ergebnis\Classy\Test\Fixture\Classy\Php73\WithinNamespace;

class Foo {}

interface Bar {}

trait Baz {}
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace Ergebnis\Classy\Test\Fixture\Classy\Php72\WithinNamespaceAndMultiLineComments;
namespace Ergebnis\Classy\Test\Fixture\Classy\Php73\WithinNamespaceAndMultiLineComments;

/* foo */ class /* bar */ Foo /* baz */ {}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace Ergebnis\Classy\Test\Fixture\Classy\Php72\WithinNamespaceAndShellStyleComments;
namespace Ergebnis\Classy\Test\Fixture\Classy\Php73\WithinNamespaceAndShellStyleComments;

class # foo
Foo # bar
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace Ergebnis\Classy\Test\Fixture\Classy\Php72\WithinNamespaceAndSingleLineComments;
namespace Ergebnis\Classy\Test\Fixture\Classy\Php73\WithinNamespaceAndSingleLineComments;

class // foo
Foo // bar
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace Ergebnis\Classy\Test\Fixture\Classy\Php72\WithinNamespaceWithBraces
namespace Ergebnis\Classy\Test\Fixture\Classy\Php73\WithinNamespaceWithBraces
{
class Foo {}

Expand Down
Loading

0 comments on commit 66d64e1

Please sign in to comment.