Allow disabling clang-tidy only for headers #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since bazel doesn't automatically build headers in isolation unless you enable parse_headers (which only recently works at all), headers may not pass clang-tidy in isolation. This adds a new `no-clang-tidy-headers` tag that can be added to libraries so that only their source files are clang-tidy'd
|
Thanks! merged. I think it is wasteful to check the extension multiple types (in check_valid_file_types and at the end), perhaps those two should be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since bazel doesn't automatically build headers in isolation unless you
enable parse_headers (which only recently works at all), headers may not
pass clang-tidy in isolation. This adds a new
no-clang-tidy-headerstag that can be added to libraries so that only their source files are
clang-tidy'd