This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Account for more corner cases w/ section search. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmc333333
force-pushed
the
475-better-search
branch
from
25c5ee3 to
262c9cd
Compare
added 2 commits
August 17, 2017 15:07
Case 1: A search matches a node's title, but the node doesn't have text. In this situation, we return text for the first child of that node. Case 2: A search which matches a section, but none of its paragraphs contain all of the search term. Here, we return text for the first child of the section.
While it's very likely this library works correctly on PyPy, Travis's version is outdated, causing build issues. Given that we have no known PyPy users, dropping support in favor of maintainability seems like a win.
cmc333333
force-pushed
the
475-better-search
branch
from
262c9cd to
9d19e94
Compare
|
Thanks @tadhg-ohiggins. I'm going to bump the version then merge. |
New Features * #84 Include additional text when searching sections using pgsql. Also, add more title fields to give additional context to search results.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Case 1: A search matches a node's title, but the node doesn't have text. In
this situation, we return text for the first child of that node.
Case 2: A search which matches a section, but none of its paragraphs contain
all of the search term. Here, we return text for the first child of the
section.