This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Use webargs for search argument parsing. #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 1, 2017 18:49
We want to create swappable search backends (we'll be adding a Postgres full-text-search shortly). Rather than continuing to copy-paste our custom argument parsing solution, use `webargs` to handle type conversions and argument validation. It probably makes sense to use this more widely, but this is a start.
This reduces the duplication a tad more.
tadhg-ohiggins
approved these changes
Aug 3, 2017
|
Thanks @tadhg-ohiggins ! |
cmc333333
pushed a commit
that referenced
this pull request
Aug 10, 2017
Breaking Changes * #79 "django.contrib.contenttypes" is now included in library's base settings. If copying these over, you'll need to deduplicate. New Features * #79 Allow search handler to be defined via `SEARCH_HANDLER` setting * #83 Allow search results page size to be requested * #82 Add Postgres backend for search. See README for details. Misc * #77 Allow ALLOWED_HOSTS to be set via env vars * #78 Use webargs library for checking search input * #80 Test different backends in different tox envs * #81 Remove QuantifiedCode badge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to create swappable search backends (we'll be adding a Postgres
full-text-search shortly). Rather than continuing to copy-paste our custom
argument parsing solution, use
webargsto handle type conversions andargument validation.
It probably makes sense to use this more widely, but this is a start.