feat: use trivy github action #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatus
requested review from
ashnamehrotra,
pmengelbert and
sozercan
as code owners
sozercan
reviewed
Jul 15, 2024
.github/workflows/test.yaml
Outdated
| - name: Run trivy for remover | ||
| run: trivy image --ignore-unfixed --exit-code=1 --vuln-type=os,library ${{ env.REGISTRY }}/remover:test | ||
| uses: aquasecurity/trivy-action@0.19.0 |
There was a problem hiding this comment.
can you add the commit to this please? (applies to others below too)
Suggested change
| uses: aquasecurity/trivy-action@0.19.0 | |
| uses: aquasecurity/trivy-action@d710430a6722f083d3b36b8339ff66b32f22ee55 |
|
@aviatus can you sign the DCO when you get a chance? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Ahmet Enes Yildiz <aenes45@gmail.com>
Signed-off-by: Ahmet Enes Yildiz <aenes45@gmail.com>
aviatus
force-pushed
the
use-trivy-github-action
branch
from
cb866e0 to
73817d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The trivy downloading binary has been replaced with trivy github action on test.yaml
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #860
Special notes for your reviewer:
For consistency of Trivy version aquasecurity/trivy-action@0.19.0 was used but patch version was implemented by that (0.50.0 -> 0.50.1).