Report all missing options at once #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -93,6 +93,7 @@ public function testRequiredOptions() | |||
| /** | |||
| * @expectedException \Equip\Command\CommandException | |||
| * @expectedExceptionCode \Equip\Command\CommandException::MISSING_OPTION | |||
| * @expectedExceptionRegExp /required options not defined:/i | |||
There was a problem hiding this comment.
Unless I'm missing something, it would be nice to see a test that lists of the missing options.
required options not defined: `user_id`, `article_id`
There was a problem hiding this comment.
Sure, I suppose... I figured adding a message that definitely comes from missingOptions would be enough.
There was a problem hiding this comment.
It just doesn't cover the:
`%s`', implode('`, `', $names)
portion of it.
Reduces annoyance when failing to define multiple required options by reporting all missing options in a single exception.
shadowhand
force-pushed
the
feature/exception-multiple-options
branch
from
3bec61e
to
11022ad
Compare
| CommandException::class, | ||
| '', | ||
| '/required options not defined.+user_id.+article_id/i', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces annoyance when failing to define multiple required options by
reporting all missing options in a single exception.