fix: Fixed string type logs not being rendered #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anders2303
added
bug
w1nklr
approved these changes
Feb 13, 2025
|
Are the color changes in the images expected ? |
Yes 👍
|
hkfb
pushed a commit
that referenced
this pull request
Feb 13, 2025
## [2.3.2](https://github.com/equinor/webviz-subsurface-components/compare/well-log-viewer@2.3.1...well-log-viewer@2.3.2) (2025-02-13) ### Bug Fixes * Fixed string type logs not being rendered ([#2440](#2440)) ([90acb69](90acb69))
|
🎉 This issue has been resolved in version well-log-viewer@2.3.2 🎉 The release is available on GitHub release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tracks.ts/setupPlothad an error that caused all curvesvaluetype: "string"to be skipped. Fixed it so that stacked curves once again support string values. Also updated the "Discrete" storybook example to include a string-value curve, so that future smoke-tests can notice this type of error.I also tweaked some internals in tracks.ts while I was at it; renamed some internal functions and variables, and made sure that styles are applied before
setupPlotis called (this is to ensure we have the full props when validating them). Note: a side-effect of this is thatgenerateColor()is called a little more often, so the smoke-tests screenshots have been updated to accommodate for new colors