Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Well clutter #2424

Merged
merged 14 commits into from
Jan 31, 2025
Merged

feat: Well clutter #2424

merged 14 commits into from
Jan 31, 2025

Conversation

nilscb
Copy link
Collaborator

@nilscb nilscb commented Jan 24, 2025 •
edited
Loading

Introduced new property on wells: "wellNameReduceClutter;"
When set deck.gl's CollisionFilterExtension is enabled to hide overlapping names.
From the documentation: "not as good as a full collision test".

@nilscb nilscb linked an issue Jan 24, 2025 that may be closed by this pull request
[NGRM] - Reduce well names cluttering. #2423
Closed
@nilscb nilscb changed the title Well clutter feat: Well clutter Jan 24, 2025
@w1nklr
Copy link
Collaborator

w1nklr commented Jan 27, 2025

Isn't reduceWellNameClutter better ?

@hkfb
Copy link
Collaborator

hkfb commented Jan 27, 2025

There appears to be some label flickering even if there is no apparent collision between the labels. Eg the label "C6" appears to not overlap with any other labels but sometimes disappears:
image
image

w1nklr
w1nklr requested changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@w1nklr w1nklr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, why are the well names displayed for the simplified well rendering ?

typescript/packages/subsurface-viewer/src/layers/wells/wellsLayer.ts Outdated Show resolved Hide resolved
typescript/packages/subsurface-viewer/src/layers/wells/wellsLayer.ts Outdated Show resolved Hide resolved
typescript/packages/subsurface-viewer/src/layers/wells/wellsLayer.ts Outdated Show resolved Hide resolved
typescript/packages/subsurface-viewer/src/layers/wells/wellsLayer.ts Outdated Show resolved Hide resolved
w1nklr
w1nklr requested changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@w1nklr w1nklr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check comments in the review

@nilscb
Copy link
Collaborator Author

nilscb commented Jan 30, 2025

Should be ok now.

@nilscb nilscb requested a review from w1nklr January 31, 2025 08:54
@nilscb nilscb merged commit 7ceedaf into equinor:master Jan 31, 2025
10 checks passed
hkfb pushed a commit that referenced this pull request Jan 31, 2025
@semantic-release-bot
chore(release): subsurface-viewer@1.7.0 [skip ci]
a6a412c 
# [1.7.0](https://github.com/equinor/webviz-subsurface-components/compare/subsurface-viewer@1.6.1...subsurface-viewer@1.7.0) (2025-01-31)

### Features

* Well clutter ([#2424](#2424)) ([7ceedaf](7ceedaf))
@hkfb
Copy link
Collaborator

hkfb commented Jan 31, 2025

🎉 This issue has been resolved in version subsurface-viewer@1.7.0 🎉

The release is available on GitHub release

@hkfb hkfb added the released label Jan 31, 2025
@nilscb nilscb deleted the WellClutter branch January 31, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkfb hkfb hkfb approved these changes

@w1nklr w1nklr w1nklr approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NGRM] - Reduce well names cluttering.
3 participants
@nilscb @w1nklr @hkfb