Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change auth provider precedence #159

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Change auth provider precedence #159

merged 1 commit into from
Oct 12, 2023

Conversation

adnejacobsen
Copy link
Contributor

I experienced some issues in the aggregation service with the new auth provider logic. I'm constructing a SumoClient with a user access token to make requests on behalf of the user, but since the AZURE_* environment variables are present it ends up using the managed identity.

@adnejacobsen adnejacobsen requested review from rwiker and a team October 12, 2023 10:21
Copy link
Contributor

@ovejorgensen ovejorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adnejacobsen adnejacobsen merged commit faf3acc into main Oct 12, 2023
6 checks passed
@adnejacobsen adnejacobsen deleted the auth-provider-logic branch October 12, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants