-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for CSV_EXPORT2 #214
Conversation
0d75d2a
to
cca5b02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks for adding documentation! Could you add a test checking that the description and examples are valid rst
? They are, but for future use. Could be something like this: https://github.com/equinor/semeio/blob/master/tests/jobs/correlated_observations_scaling/unit/test_examples.py
Also, can you link it to the corresponding issue?
Not enough privileges to link to issues.. |
Ahh, closes #214 |
MAKE_DIRECTORY <CONFIG_PATH>/ert/output/csv I would suggest to write output to the scratch disk (instead of the project disk), |
Would it be useful to add to the examples or description some tips on how to avoid too large csv files? |
This needs to be in the description of the PR |
Such high requirements! :p |
Thinking of vector selection or time frequency? Example tip? |
Done. |
6c33925
to
0323923
Compare
Both, i see time interval examples is covered now. Though convenient the * notation may easily dump much more vectors than the user needs(?) But maybe this should be left to the user to judge...? As an example, using WOPT*, WWPT*, WGPT* instead of W* can make a huge difference |
Everything looks good from my perspective, but @rnyb is probably better placed to review the contents of the docs. So when he is happy this can be merged. |
I think it looks good now |
NB: "weekly" will not work before komodo 2020.10 is stable. |
Is it a lot of work to split that into a separate PR that we can merge when that is closer in time? Normally that should be so close that it would not be a problem, but might be delayed. Other than that, rebase and it is good to go. |
Great, can you also create an issue or a PR straight away so we dont forget? |
21d8002
to
d5b5863
Compare
Rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for adding docs!
Closes #193