Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for CSV_EXPORT2 #214

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Conversation

berland
Copy link
Collaborator

@berland berland commented Sep 30, 2020

Closes #193

@berland berland force-pushed the csvexport2docs branch 2 times, most recently from 0d75d2a to cca5b02 Compare September 30, 2020 11:44
Copy link
Contributor

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for adding documentation! Could you add a test checking that the description and examples are valid rst? They are, but for future use. Could be something like this: https://github.com/equinor/semeio/blob/master/tests/jobs/correlated_observations_scaling/unit/test_examples.py

Also, can you link it to the corresponding issue?

semeio/workflows/csv_export2/csv_export2.py Show resolved Hide resolved
@berland
Copy link
Collaborator Author

berland commented Oct 1, 2020

Also, can you link it to the corresponding issue?

Not enough privileges to link to issues..

@oyvindeide
Copy link
Contributor

Ahh, closes #214

@rnyb
Copy link

rnyb commented Oct 1, 2020

MAKE_DIRECTORY <CONFIG_PATH>/ert/output/csv
CSV_EXPORT2 <RUNPATH_FILE> <CONFIG_PATH>/ert/output/csv/.csv monthly F* W* TCPU TIMESTEP

I would suggest to write output to the scratch disk (instead of the project disk),
in .../<case_dir>/share/someoutputfolder/...

@rnyb
Copy link

rnyb commented Oct 1, 2020

Would it be useful to add to the examples or description some tips on how to avoid too large csv files?

@sondreso
Copy link
Contributor

sondreso commented Oct 1, 2020

Ahh, closes #214

This needs to be in the description of the PR ☺️ (And probably point to the issue and not the PR?)

@oyvindeide
Copy link
Contributor

Ahh, closes #214

This needs to be in the description of the PR ☺️ (And probably point to the issue and not the PR?)

Such high requirements! :p

@berland
Copy link
Collaborator Author

berland commented Oct 1, 2020

Would it be useful to add to the examples or description some tips on how to avoid too large csv files?

Thinking of vector selection or time frequency? Example tip?

@berland
Copy link
Collaborator Author

berland commented Oct 1, 2020

MAKE_DIRECTORY <CONFIG_PATH>/ert/output/csv
CSV_EXPORT2 <RUNPATH_FILE> <CONFIG_PATH>/ert/output/csv/.csv monthly F* W* TCPU TIMESTEP

I would suggest to write output to the scratch disk (instead of the project disk),
in .../<case_dir>/share/someoutputfolder/...

Done.

@rnyb
Copy link

rnyb commented Oct 1, 2020

Would it be useful to add to the examples or description some tips on how to avoid too large csv files?

Thinking of vector selection or time frequency? Example tip?

Both, i see time interval examples is covered now. Though convenient the * notation may easily dump much more vectors than the user needs(?) But maybe this should be left to the user to judge...?

As an example, using WOPT*, WWPT*, WGPT* instead of W* can make a huge difference

@oyvindeide
Copy link
Contributor

Everything looks good from my perspective, but @rnyb is probably better placed to review the contents of the docs. So when he is happy this can be merged.

@rnyb
Copy link

rnyb commented Oct 1, 2020

Everything looks good from my perspective, but @rnyb is probably better placed to review the contents of the docs. So when he is happy this can be merged.

I think it looks good now

@berland
Copy link
Collaborator Author

berland commented Oct 1, 2020

NB: "weekly" will not work before komodo 2020.10 is stable.

@oyvindeide
Copy link
Contributor

NB: "weekly" will not work before komodo 2020.10 is stable.

Is it a lot of work to split that into a separate PR that we can merge when that is closer in time? Normally that should be so close that it would not be a problem, but might be delayed.

Other than that, rebase and it is good to go.

@oyvindeide
Copy link
Contributor

Great, can you also create an issue or a PR straight away so we dont forget?

@berland
Copy link
Collaborator Author

berland commented Oct 1, 2020

Rebased.

Copy link
Contributor

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding docs!

@oyvindeide oyvindeide merged commit d5a9b92 into equinor:master Oct 1, 2020
@berland berland deleted the csvexport2docs branch July 6, 2021 07:23
dafeda pushed a commit that referenced this pull request Nov 21, 2024
dafeda pushed a commit to dafeda/semeio that referenced this pull request Nov 27, 2024
dafeda pushed a commit that referenced this pull request Nov 27, 2024
dafeda pushed a commit that referenced this pull request Nov 27, 2024
dafeda pushed a commit that referenced this pull request Nov 27, 2024
dafeda pushed a commit that referenced this pull request Nov 27, 2024
dafeda pushed a commit that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for CSV_EXPORT2
4 participants