Fix default UPDATE_KEYS with threshold in CALCULATE_KEYS #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -72,7 +72,9 @@ def _realize_list(input_string): | |||
| def _expand_input(input_value): | |||
| expanded_values = deepcopy(input_value) | |||
| if "CALCULATE_KEYS" in expanded_values and "UPDATE_KEYS" not in expanded_values: | |||
| expanded_values.update({"UPDATE_KEYS": expanded_values["CALCULATE_KEYS"]}) | |||
| expanded_values.update( | |||
There was a problem hiding this comment.
Should this not have been caught in the test_expand_input?
There was a problem hiding this comment.
Good catch, yes it should, is now.
oyvindeide
force-pushed
the
fix_default_update_keys
branch
from
4393baf to
579289b
Compare
oyvindeide
force-pushed
the
fix_default_update_keys
branch
from
579289b to
1e24b1a
Compare
lars-petter-hauge
approved these changes
Jan 9, 2020
dafeda
pushed a commit
to dafeda/semeio
that referenced
this pull request
Nov 27, 2024
dafeda
pushed a commit
to dafeda/semeio
that referenced
this pull request
Nov 27, 2024
…older for fmudesign
dafeda
pushed a commit
that referenced
this pull request
Nov 27, 2024
dafeda
pushed a commit
that referenced
this pull request
Nov 27, 2024
dafeda
pushed a commit
that referenced
this pull request
Nov 27, 2024
dafeda
pushed a commit
that referenced
this pull request
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.