Test suite updates #595
Merged
Test suite updates #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segyio-shared target was removed and exchanged with segyio target in af2059a
These script are intended to be run as tests, but there is no visible information whether scripts were actually executed. Wrapping them up in print statements gives us confidence that scripts were run from start to finish.
There is no plan to do anything with matlab bindings (we are not sure if we won't drop them whatsoever), but it would be useful to know if we accidentally break something in the future. Github actions allow us to use matlab. While originally intended way of running tests with ctests doesn't work for some reason (probably due to matlab setup in github actions), we still can run scripts there directly as commands.
6e84e4d changed the way tests were written, but doing so dropped separation between c.segy and c++ tests. By bringing it back we remove duplicated test runs (reducing cases run in test entities 1-4 from 101 to 81, by 20 tests that belong to the c++ group and are not affected by mmap/lsb distinction). Note that c++ code is built and tests are run regardless of the "experimental" build option. That option impacts installation only.
yngve793
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.