Additional readthedocs fixes #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Readthedocs doesn't compile the code and thus fails. The simplest solution is to change version manually with every release.
I however don't think it is used anywhere in the documentation, so it is likely it could be safely deleted instead.
ajaust
approved these changes
Jan 31, 2025
| # static analysis flags the subproces module as a potential security | ||
| # problem, but this takes no user input and should be safe | ||
| from subprocess import check_output # nosec | ||
| version = str(check_output(['git', 'describe']).strip()) # nosec |
There was a problem hiding this comment.
Just a finding that supports removal of this code part:
Out of curiosity I checked the output of git describe on my master branch. It gives me v1.9.6-76-g62c10d0 which I find surprising since the latest tag is v1.9.12. I wonder when/why git describe broke for this repository.
There was a problem hiding this comment.
I never could understand this versioning thing, so good to see it seems properly broken and thus can be removed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.