Remove handling of normals in fbximporter #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strepto
reviewed
Mar 21, 2025
Comment on lines
-18
to
-22
| //this should never be called in the first place if the SDK is invalid | ||
| if (!_sdk.IsValid()) | ||
| { | ||
| throw new NullReferenceException("Cannot load files with invalid SDK."); | ||
| } |
There was a problem hiding this comment.
Why is this check removed?
There was a problem hiding this comment.
There is another call to this function in FbxWorkload (ReadFbxData), where it checks this before calling the LoadFile function of the FbxImporter
Strepto
reviewed
Mar 21, 2025
| @@ -78,7 +78,7 @@ public static (IReadOnlyList<CadRevealNode>, ModelMetadata?) ReadFbxData( | |||
| var progress = 0; | |||
|
|
|||
| // FBX Importer is intentionally not disposed as the dispose operation takes too long. If this becomes a problem with memory leaks we need to investigate why the dispose is so slow. | |||
| var fbxImporter = new FbxImporter(); | |||
| using var fbxImporter = new FbxImporter(); | |||
There was a problem hiding this comment.
Either remove the using or update the comment.
Strepto
reviewed
Mar 21, 2025
Strepto
reviewed
Mar 21, 2025
stigrus
force-pushed
the
ssob/fbximporter-remove-normals
branch
from
1205d83 to
0496cb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have I made? 👩💻
Removed handling of normals in the FBX importer, since they are not used by the CadRevealFbxProvider anyways.
Benchmark
Benchmark of fbximporter reading normals vs not handling normals.
Benchmarks performed using BenchmarkDotNet.
How can you best review this? 🧐
Make sure fbx files are imported properly.
Did I remember everything checklist?