Have komodo cli remove hidden release dir after rsync #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-eq
force-pushed
the
remove-hidden-folder-in-build-script
branch
3 times, most recently
from
fe6e61c
to
1c3dba1
Compare
larsevj
reviewed
Aug 30, 2024
| @@ -248,6 +247,7 @@ def delete_old_previously_moved_releases(prefix_path: Path, release_name: Path) | |||
| "rm -rf -- " + " ".join(release_dir_glob), | |||
| allow_failure=True, | |||
| ) | |||
| shell(f"rm -rf .{release_name}") | |||
There was a problem hiding this comment.
Unsure if this is necessary. In actual use we build in a tmpdir that gets deleted once the build has finished.
And I am not sure if this is the correct path to delete from? Apart from in the tests, I do not think that anyone actually build komodo locally.
There was a problem hiding this comment.
I added a test for making sure it is the correct path.
There was a problem hiding this comment.
Also, should we depend on the input directory being tmp/***, or should komodo cleanup after itself regardless?
jonathan-eq
force-pushed
the
remove-hidden-folder-in-build-script
branch
from
1c3dba1
to
e28966e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #326