Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create add poi #51

Merged
merged 4 commits into from
Mar 13, 2023
Merged

Create add poi #51

merged 4 commits into from
Mar 13, 2023

Conversation

OleDrange
Copy link
Contributor

No description provided.

@OleDrange OleDrange force-pushed the create_AddPOI branch 5 times, most recently from 35a30d7 to a7cd413 Compare March 9, 2023 12:11
@OleDrange OleDrange requested a review from Afonso-2403 March 9, 2023 12:13
@OleDrange
Copy link
Contributor Author

closes #43

Afonso-2403
Afonso-2403 suggested changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@Afonso-2403 Afonso-2403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me apart from a couple of typos :)

src/isar_exr/api/energy_robotics_api.py Outdated Show resolved Hide resolved
tests/api/test_energy_robotics_api.py Outdated Show resolved Hide resolved
tests/api/test_energy_robotics_api.py Outdated Show resolved Hide resolved
tests/api/test_energy_robotics_api.py Outdated Show resolved Hide resolved
@OleDrange
Fix writing errors
3d54a4b 
Change _ to cap letter in class name
@OleDrange OleDrange requested a review from Afonso-2403 March 10, 2023 14:03
Christdej
Christdej approved these changes Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@Christdej Christdej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OleDrange OleDrange mentioned this pull request Mar 13, 2023
Merged
Afonso-2403
Afonso-2403 approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@Afonso-2403 Afonso-2403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OleDrange OleDrange merged commit 37f08de into equinor:main Mar 13, 2023
@OleDrange OleDrange deleted the create_AddPOI branch March 13, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Afonso-2403 Afonso-2403 Afonso-2403 approved these changes

@Christdej Christdej Christdej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OleDrange @Christdej @Afonso-2403