Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize #49

Merged
merged 4 commits into from
Mar 7, 2023
Merged

Initialize #49

merged 4 commits into from
Mar 7, 2023

Conversation

MortFred
Copy link
Contributor

@MortFred MortFred commented Mar 3, 2023

Closes #41 and #27

@MortFred MortFred force-pushed the initialize branch 4 times, most recently from 619590f to 9215eb9 Compare March 3, 2023 13:15
GodVenn
GodVenn suggested changes Mar 3, 2023
View reviewed changes
src/isar_exr/api/energy_robotics_api.py Outdated Show resolved Hide resolved
src/isar_exr/api/energy_robotics_api.py Outdated Show resolved Hide resolved
@MortFred MortFred force-pushed the initialize branch 3 times, most recently from 6377533 to 4d4939d Compare March 3, 2023 13:52
GodVenn
GodVenn reviewed Mar 3, 2023
View reviewed changes
Copy link
Contributor

@GodVenn GodVenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting a rename and adding a comment explaining the variable

src/isar_exr/config/settings.py Outdated Show resolved Hide resolved
GodVenn
GodVenn suggested changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@GodVenn GodVenn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add tests for wake_up_robot and is_robot_awake ?

@MortFred MortFred force-pushed the initialize branch 4 times, most recently from 698a2df to 2159704 Compare March 7, 2023 14:18
GodVenn
GodVenn reviewed Mar 7, 2023
View reviewed changes
Copy link
Contributor

@GodVenn GodVenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commits don't really reflect what they change, is it possible to take parts of the last commit "add tests" and instead squash them into their appropriate commits?

src/isar_exr/api/energy_robotics_api.py Outdated Show resolved Hide resolved
src/isar_exr/api/energy_robotics_api.py Outdated Show resolved Hide resolved
GodVenn
GodVenn approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@GodVenn GodVenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MortFred MortFred merged commit 4dfa9d9 into equinor:main Mar 7, 2023
@MortFred MortFred deleted the initialize branch March 7, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GodVenn GodVenn GodVenn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement api call to robot status
2 participants
@MortFred @GodVenn