Add create_mission_definition and start_mission_exicution #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OleDrange
force-pushed
the
missiondefinition
branch
5 times, most recently
from
be5c9ef to
9159c58
Compare
| } | ||
|
|
||
| try: | ||
| response_dict: dict[str, Any] = self.client.query(mutation_string, params) |
There was a problem hiding this comment.
is it sufficient to say dict?
There was a problem hiding this comment.
dont know what you mean. It's the same as the other functions we have made. Il just let it stand and we can update it later maby
GodVenn
suggested changes
Mar 3, 2023
|
Can you add tests for these functions? |
OleDrange
force-pushed
the
missiondefinition
branch
4 times, most recently
from
4b22f06 to
90c1cab
Compare
OleDrange
force-pushed
the
missiondefinition
branch
from
90c1cab to
18cef40
Compare
OleDrange
force-pushed
the
missiondefinition
branch
from
18cef40 to
9e2cde6
Compare
OleDrange
force-pushed
the
missiondefinition
branch
from
9e2cde6 to
1cabb27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.