Implement step status #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andchiind
force-pushed
the
implement-step-status
branch
8 times, most recently
from
13668b7 to
e99a754
Compare
Afonso-2403
reviewed
Feb 29, 2024
Comment on lines
+271
to
+274
| step: List[str] = list( | ||
| filter(lambda step: current_task_id in step, self.mission_task_ids) | ||
| )[0] | ||
| task_index: int = self.mission_task_ids.index(step) |
There was a problem hiding this comment.
Can't this just be simplified to the suggestion below?
Suggested change
| step: List[str] = list( | |
| filter(lambda step: current_task_id in step, self.mission_task_ids) | |
| )[0] | |
| task_index: int = self.mission_task_ids.index(step) | |
| task_index: int = self.mission_task_ids.index(current_task_id) |
There was a problem hiding this comment.
In this case self.mission_task_ids is a 2D array, where the first dimension is the task and the inner dimension is the steps within that task. This is maybe not a good name for the object; it has the name since it started off as an array of task IDs. Since we are trying to find the index which contains a task which in turn contains current_task_id as a step, we need to first do this filtering to find the right task based on its steps, before we can use it to find the right task index.
Afonso-2403
reviewed
Feb 29, 2024
andchiind
force-pushed
the
implement-step-status
branch
from
e99a754 to
20cd27d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.