-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace CircleCI with Github Actions #821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely nicer than the circle setup
Looks cool! |
Codecov Report
@@ Coverage Diff @@
## master #821 +/- ##
==========================================
- Coverage 92.73% 92.48% -0.25%
==========================================
Files 58 58
Lines 2835 2835
==========================================
- Hits 2629 2622 -7
- Misses 206 213 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modern
Should be enough to make the switch, but can be made more fancy by pulling out the deploy steps, tests, image and docs building into their own workflows later if we want.
Benefits 🦄
Cons 🎠
Suppose we can store this PR until it is supported?