Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CircleCI with Github Actions #821

Merged
merged 3 commits into from
Jan 6, 2020
Merged

Replace CircleCI with Github Actions #821

merged 3 commits into from
Jan 6, 2020

Conversation

milesgranger
Copy link
Contributor

@milesgranger milesgranger commented Dec 30, 2019

Should be enough to make the switch, but can be made more fancy by pulling out the deploy steps, tests, image and docs building into their own workflows later if we want.

Benefits 🦄

  • Super easy matrix config, can easily run tests on different OS, python version, ...
  • Better concurrency... all tests for all components start right away.. unlike CircleCI limit of 4 containers
  • Less YAML

Cons 🎠

Suppose we can store this PR until it is supported?

@milesgranger milesgranger reopened this Dec 30, 2019
@milesgranger milesgranger changed the title [WIP] Try out github actions Replace CircleCI with Github Actions Dec 30, 2019
@milesgranger milesgranger marked this pull request as ready for review December 30, 2019 10:37
Copy link
Contributor

@epa095 epa095 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely nicer than the circle setup

.github/workflows/main.yml Outdated Show resolved Hide resolved
@EinarJohnsen
Copy link
Contributor

Looks cool!

@codecov
Copy link

codecov bot commented Jan 3, 2020

Codecov Report

Merging #821 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #821      +/-   ##
==========================================
- Coverage   92.73%   92.48%   -0.25%     
==========================================
  Files          58       58              
  Lines        2835     2835              
==========================================
- Hits         2629     2622       -7     
- Misses        206      213       +7
Impacted Files Coverage Δ
gordo_components/machine/model/models.py 95.55% <0%> (-2.78%) ⬇️
gordo_components/builder/mlflow_utils.py 97.03% <0%> (-1.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a72fa...617d32a. Read the comment docs.

Copy link
Contributor

@flikka flikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modern

@milesgranger milesgranger merged commit b3a7561 into equinor:master Jan 6, 2020
@milesgranger milesgranger deleted the github-actions branch January 6, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants