Catch a possible error in STATUS files #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berland
force-pushed
the
avoid_indexerror
branch
2 times, most recently
from
6b89683 to
c19e015
Compare
berland
force-pushed
the
avoid_indexerror
branch
from
c19e015 to
5858a95
Compare
|
This should include an issue and at least an explanation about the problem. |
Fixed! |
|
This PR is doing an educated guess on what could have happened when the traceback in the original issue occured, adds a test to reproduce it, and then catches the exception to handle the error gracefully. |
xjules
reviewed
Aug 23, 2024
tests/test_realization.py
Outdated
| @@ -253,6 +253,24 @@ def test_status_load(tmpdir): | |||
| assert "FORWARD_MODEL" in status | |||
| assert np.isnan(status["DURATION"].values[0]) # Unsupported time syntax | |||
|
|
|||
| with open(str(tmpdir.join("realization-0/STATUS")), "w") as status_fh: | |||
There was a problem hiding this comment.
This single test function does a lot! Would be it possible to actually split it to some smaller test functions?
Instead of crashing, we should ignore the line in a garbled STATUS file like we do for other ways it can be garbled.
berland
force-pushed
the
avoid_indexerror
branch
from
5858a95 to
c22b875
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of crashing, we should ignore the line in a garbled STATUS file like we do for other ways it can be garbled.