Replace ecl with resdata #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #234 +/- ##
=======================================
Coverage 83.31% 83.31%
=======================================
Files 14 14
Lines 3026 3026
=======================================
Hits 2521 2521
Misses 505 505 ☔ View full report in Codecov by Sentry. |
|
@berland Any idea why the tests are not starting? does this PR need to be verified by an admin? I tried making a PR from a branch created on the main repo but I got the same result. |
|
The workflows were disabled due to inactivity. Now enabled again. |
DanSava
force-pushed
the
replace_ecl
branch
2 times, most recently
from
4614693 to
1ee15c4
Compare
andreas-el
approved these changes
Nov 15, 2023
DanSava
added a commit
that referenced
this pull request
Nov 22, 2023
* Replace ecl with resdata * Fix doc yaml block * Lock setuptools_scm version * Fix doc building (cherry picked from commit 459ddb0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/equinor/scout/issues/924