MAINT: Stop modifying schemas in Docker #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change moves the dev and prod url changes and checks to the dev release side. It is checked in the 'staging' branch so that it happens explicitly.
mferrera
commented
Jan 14, 2025
| RUN chown -R 101 . | ||
| RUN apk update && apk upgrade && apk add jq |
There was a problem hiding this comment.
This was only needed for modifying the schema files, but it increases consistency. It's not great practice to update & upgrade packages in a Docker image like this because it means every deployment could potentially have different versions of things outside of what nginx has released in their image. That also has security implications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #966
This change moves the dev and prod url changes to part of the release process (running
SCHEMA_RELEASE=1 ./tools/update-schemain the staging branch). It is checked in the 'staging' branch so that it happens explicitly.See https://github.com/equinor/fmu-dataio/actions/runs/12671501765/job/35313394311?pr=960#step:6:13 for an example of how this looks.